Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CodeBanner text with better temporary one #8077

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Replace CodeBanner text with better temporary one #8077

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63a4970
Replace CodeBanner text with better temporary one
Jan 5, 2023
66bc9d3
Update orion-ui/src/pages/WorkerPoolQueue.vue
marichka-offen Jan 5, 2023
15a8874
Merge branch 'main' of https://github.com/PrefectHQ/prefect into work…
Jan 5, 2023
4014ad3
Merge branch 'work-pool-queue-cli-command' of https://github.com/Pref…
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions orion-ui/src/pages/WorkerPoolQueue.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@

<p-layout-well class="worker-pool-queue__body">
<template #header>
<!-- Update banner with correct information -->
<CodeBanner :command="workerPoolQueueCliCommand" title="Worker pool queue is ready to go!" subtitle="Worker Pool Queue description" />
<CodeBanner :command="workerPoolQueueCliCommand" title="Worker pool queue is ready to go!" subtitle="Work queues are scoped to a specific work pool to ensure that the work put into a queue will only be picked up by a specific type of worker." />
</template>

<p-tabs :tabs="tabs">
Expand Down Expand Up @@ -48,7 +47,11 @@
const workerPoolQueuesSubscription = useSubscription(api.workerPoolQueues.getWorkerPoolQueueByName, [workerPoolName.value, workerPoolQueueName.value], subscriptionOptions)
const workerPoolQueue = computed(() => workerPoolQueuesSubscription.response)

const workerPoolQueueCliCommand = computed(() => 'code snippet for worker pool queue')
const workerPoolWorkersSubscription = useSubscription(api.workerPoolWorkers.getWorkers, [workerPoolName.value], subscriptionOptions)
const workerPoolWorkers = computed(() => workerPoolWorkersSubscription.response ?? [])
const workerPoolWorkerName = computed(() => workerPoolWorkers.value[0]?.name ?? '<worker name>')
pleek91 marked this conversation as resolved.
Show resolved Hide resolved

const workerPoolQueueCliCommand = computed(() => `prefect worker start --pool ${workerPoolName.value} --name ${workerPoolWorkerName.value} *--queue ${workerPoolQueueName.value}`)

const flowRunFilter = useFlowRunFilter({ workerPoolQueueName: [workerPoolQueueName.value] })

Expand Down