Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default task run name to exclude hash of task key #8292

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Jan 27, 2023

Supersedes #8287

The task run name isn't very user friendly by default and since we're showing task run names in lots of places we'd like the default to be focused on human readability. The task key will still be available in details. This will allow us to improve readability of task runs in the UI without short-term patches that would complicate design once we allow users to set their own task run names.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@netlify
Copy link

netlify bot commented Jan 27, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit e4e5847
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63d42a1c0f4c0c0009b13a11
😎 Deploy Preview https://deploy-preview-8292--prefect-orion.netlify.app/api-ref/prefect/engine
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb added the enhancement An improvement of an existing feature label Jan 27, 2023
@zanieb zanieb marked this pull request as ready for review January 27, 2023 21:04
@zanieb zanieb requested a review from a team as a code owner January 27, 2023 21:04
@zanieb
Copy link
Contributor Author

zanieb commented Jan 27, 2023

Apparently, this is currently untested! I'm not sure I feel like we need to make assertions about the default task run names but it could be kind of nice to add coverage now?

@zanieb
Copy link
Contributor Author

zanieb commented Jan 27, 2023

@ahuang11 this won't break the Dask task key right?

@zanieb zanieb merged commit 773dd9f into main Jan 27, 2023
@zanieb zanieb deleted the default-task-run-names branch January 27, 2023 22:15
@ahuang11
Copy link
Contributor

@ahuang11 this won't break the Dask task key right?

It's separate but I wonder how this shows up in the graph.
https://github.com/PrefectHQ/prefect-dask/blob/main/prefect_dask/task_runners.py#L227-L234

@zanieb
Copy link
Contributor Author

zanieb commented Jan 27, 2023

@ahuang11 it should display the same since Dask just eats up to the first hyphen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants