Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maintenance] Update isort to fix errors in CI #8298

Merged
merged 1 commit into from
Jan 30, 2023
Merged

[maintenance] Update isort to fix errors in CI #8298

merged 1 commit into from
Jan 30, 2023

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jan 29, 2023

Our CI jobs have begun failing (some examples here and here), and also this issue is reproducible locally. After doing some sleuthing, the issue is resolved by upgrading isort.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Jan 29, 2023
@netlify
Copy link

netlify bot commented Jan 29, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 87e2929
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63d6d6d9099ee10008e38342
😎 Deploy Preview https://deploy-preview-8298--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cicdw cicdw marked this pull request as ready for review January 29, 2023 20:28
@cicdw cicdw requested a review from a team as a code owner January 29, 2023 20:28
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@zhen0
Copy link
Member

zhen0 commented Jan 30, 2023

Thanks Chris!

@zanieb zanieb merged commit ee4e3dd into main Jan 30, 2023
@zanieb zanieb deleted the fix-linters branch January 30, 2023 15:39
ddelange added a commit to ddelange/prefect that referenced this pull request Feb 1, 2023
…erm-testing

* 'main' of https://github.com/prefecthq/prefect: (40 commits)
  Expand `work_queue` table to accommodate work pools (PrefectHQ#8264)
  Update issue label workflow (PrefectHQ#8334)
  Add `PREFECT_LOGGING_ORION_WHEN_MISSING_FLOW` setting to handle error raised when logs outside of flow run context (PrefectHQ#8311)
  Fix tests for scheduled flow runs CLI `--start-at` option (PrefectHQ#8330)
  allow snakecase in maps folder (PrefectHQ#8322)
  Bump @prefecthq/vue-compositions from 1.3.0 to 1.3.3 in /orion-ui (PrefectHQ#8328)
  Bump typescript from 4.9.4 to 4.9.5 in /orion-ui (PrefectHQ#8325)
  Bump @prefecthq/orion-design from 1.2.8 to 1.2.9 in /orion-ui (PrefectHQ#8326)
  Mention reverse proxy for PREFECT_API_URL config (PrefectHQ#8240)
  Update Issue bot (PrefectHQ#8297)
  Fix Prefect Cloud typo in FAQ (PrefectHQ#8317)
  Remove unused Cloud Getting Started page (PrefectHQ#8291)
  Bump @playwright/test from 1.29.2 to 1.30.0 in /orion-ui (PrefectHQ#8313)
  Add role permissions regarding block secrets (PrefectHQ#8309)
  [maintenance] Update isort to fix errors in CI (PrefectHQ#8298)
  Add assertion for single notification and expand notification test suite (PrefectHQ#7504)
  Bump @prefecthq/orion-design from 1.2.7 to 1.2.8 in /orion-ui (PrefectHQ#8303)
  Bump @prefecthq/vue-compositions from 1.2.9 to 1.3.0 in /orion-ui (PrefectHQ#8302)
  Bump @prefecthq/prefect-design from 1.2.2 to 1.2.3 in /orion-ui (PrefectHQ#8301)
  Bump @prefecthq/eslint-config from 1.0.22 to 1.0.23 in /orion-ui (PrefectHQ#8300)
  ...
@zanieb zanieb mentioned this pull request Feb 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants