-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maintenance] Update isort to fix errors in CI #8298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
added
the
development
Tech debt, refactors, CI, tests, and other related work.
label
Jan 29, 2023
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jawnsy
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thanks Chris! |
chrisguidry
approved these changes
Jan 30, 2023
ddelange
added a commit
to ddelange/prefect
that referenced
this pull request
Feb 1, 2023
…erm-testing * 'main' of https://github.com/prefecthq/prefect: (40 commits) Expand `work_queue` table to accommodate work pools (PrefectHQ#8264) Update issue label workflow (PrefectHQ#8334) Add `PREFECT_LOGGING_ORION_WHEN_MISSING_FLOW` setting to handle error raised when logs outside of flow run context (PrefectHQ#8311) Fix tests for scheduled flow runs CLI `--start-at` option (PrefectHQ#8330) allow snakecase in maps folder (PrefectHQ#8322) Bump @prefecthq/vue-compositions from 1.3.0 to 1.3.3 in /orion-ui (PrefectHQ#8328) Bump typescript from 4.9.4 to 4.9.5 in /orion-ui (PrefectHQ#8325) Bump @prefecthq/orion-design from 1.2.8 to 1.2.9 in /orion-ui (PrefectHQ#8326) Mention reverse proxy for PREFECT_API_URL config (PrefectHQ#8240) Update Issue bot (PrefectHQ#8297) Fix Prefect Cloud typo in FAQ (PrefectHQ#8317) Remove unused Cloud Getting Started page (PrefectHQ#8291) Bump @playwright/test from 1.29.2 to 1.30.0 in /orion-ui (PrefectHQ#8313) Add role permissions regarding block secrets (PrefectHQ#8309) [maintenance] Update isort to fix errors in CI (PrefectHQ#8298) Add assertion for single notification and expand notification test suite (PrefectHQ#7504) Bump @prefecthq/orion-design from 1.2.7 to 1.2.8 in /orion-ui (PrefectHQ#8303) Bump @prefecthq/vue-compositions from 1.2.9 to 1.3.0 in /orion-ui (PrefectHQ#8302) Bump @prefecthq/prefect-design from 1.2.2 to 1.2.3 in /orion-ui (PrefectHQ#8301) Bump @prefecthq/eslint-config from 1.0.22 to 1.0.23 in /orion-ui (PrefectHQ#8300) ...
3 tasks
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI jobs have begun failing (some examples here and here), and also this issue is reproducible locally. After doing some sleuthing, the issue is resolved by upgrading
isort
.Checklist
<link to issue>
"fix
,feature
,enhancement