Fix cancellation bug #8315
Merged
Fix cancellation bug #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
chrisguidry
approved these changes
Jan 30, 2023
zanieb
reviewed
Jan 30, 2023
| @pytest.mark.parametrize( | ||
| "cancelling_constructor", [legacy_named_cancelling_state, Cancelling] | ||
| ) | ||
| async def test_agent_cancel_run_preserves_other_state_properties( |
There was a problem hiding this comment.
Can we keep this test and just include type in the expected changed fields?
zanieb
approved these changes
Jan 30, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 tasks
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agents were not properly updating
Cancellingruns to aCancelledstate after cancellation logic has fired. This update fixes that.Checklist
<link to issue>"fix,feature,enhancement