Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds default value for priority on WorkQueue core schema #8373

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Adds default value for priority on WorkQueue core schema #8373

merged 4 commits into from
Feb 2, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Feb 2, 2023 •
edited
Loading

Adds default value for priority to prevent new agents from breaking with old servers to address the issue raised here.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@desertaxle desertaxle added the fix A fix for a bug in an existing feature label Feb 2, 2023
@netlify
Copy link

netlify bot commented Feb 2, 2023 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 1424888
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63dc0f59089bf6000859ec6e
😎 Deploy Preview https://deploy-preview-8373--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb zanieb mentioned this pull request Feb 2, 2023
Merged
@desertaxle desertaxle marked this pull request as ready for review February 2, 2023 19:13
@desertaxle desertaxle requested review from a team and zangell44 as code owners February 2, 2023 19:13
zanieb
zanieb reviewed Feb 2, 2023
View reviewed changes
src/prefect/orion/models/work_queues.py Outdated
@@ -57,13 +58,16 @@ async def create_work_queue(
data["work_pool_id"] = default_agent_work_pool.id

if data.get("work_pool_id"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry (and this doesn't need to change here) but this will always be true since you set a value for this above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Took it out

@zanieb zanieb merged commit 4b2bc9e into main Feb 2, 2023
@zanieb zanieb deleted the default-priority branch February 2, 2023 19:59
@zanieb zanieb mentioned this pull request Feb 3, 2023
Merged
3 tasks
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@desertaxle @zanieb
Adds default value for priority on WorkQueue core schema (#8373)
efbccf9
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@desertaxle @zanieb
Adds default value for priority on WorkQueue core schema (#8373)
50122f8
serinamarie pushed a commit that referenced this pull request Feb 6, 2023
@desertaxle @serinamarie
Adds default value for priority on WorkQueue core schema (#8373)
bb982eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @zanieb