Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Use recentFlowRunFilter instead of flowRunFilter #8380

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Feb 2, 2023

Uses the recentFlowRunFilter instead of runFilter to match the date filter that's applied on work pools and the empty state message.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit aa822c1
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63dc1699ecd9c700099dd67e
😎 Deploy Preview https://deploy-preview-8380--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zhen0 zhen0 marked this pull request as ready for review February 2, 2023 20:01
@zhen0
Copy link
Member Author

zhen0 commented Feb 2, 2023

@marichka-offen - need your 👀 here! I'm not certain if the difference was deliberate but it feels confusing to see more runs on the queue page than its parent pool page.

Copy link
Contributor

@marichka-offen marichka-offen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants