Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: Add the ability to refresh a channel without creating a subscription #393

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

pleek91
Copy link
Collaborator

@pleek91 pleek91 commented Feb 20, 2024

Description

Introduced a refresh method on SubscriptionManager and a refreshChannel utility that wraps it. Calling refresh will refresh a channel directly without creating a new subscription. If not channel exists its a noop.

@pleek91 pleek91 requested a review from a team as a code owner February 20, 2024 22:41
Copy link
Contributor

@collincchoy collincchoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ez-peez

@pleek91 pleek91 merged commit e835e30 into main Feb 20, 2024
3 checks passed
@pleek91 pleek91 deleted the subscription-manager-refresh branch February 20, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants