Update actions to v3 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leemyongpakvn
commented
May 31, 2023
leemyongpakvn
commented
| Questions | Answers |
|---|---|
| Description? | Update actions cache v2, upload artifact v1, download artifact v1 to v3 to solve deprecated warnings. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #{issue URL here}, Fixes #{another issue URL here} |
| Sponsor company | Your company or customer's name goes here (if applicable). |
| How to test? | Build Release green in modules that use this common yml |
kpodemski
reviewed
May 31, 2023
| with: | ||
| name: ${{ github.event.repository.name }} | ||
| path: ../ | ||
| path: /home/runner/work/${{ github.event.repository.name }} |
There was a problem hiding this comment.
is it necessary to change this? do you have any source confirming this change?
There was a problem hiding this comment.
@kpodemski upload-artifact v3 does not allow ../ as path, you can see error at https://github.com/PrestaShop/pagesnotfound/pull/30/checks
The first confirmation is at https://github.com/PrestaShop/blockwishlist/pull/216/files
The second confirmation is at https://github.com/PrestaShop/pagesnotfound/pull/29/files :)
there is no automatic test for this common file
kpodemski
approved these changes
May 31, 2023
jolelievre
approved these changes
May 31, 2023
This was referenced Aug 28, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.