Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path in download-artifact action. #9

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

M0rgan01
Copy link

@M0rgan01 M0rgan01 commented Aug 29, 2023

Questions Answers
Description? When switching from download-artifact v1 to download-artifact v3, there is no more extra directory.
This results in failing the "Prepare for Release" and "Publish to GitHub Release" steps.
See https://github.com/actions/download-artifact/tree/releases/v2#compatibility-between-v1-and-v2
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #33749
Sponsor company -
How to test? -

@M0rgan01
Copy link
Author

Wait for tests in productcomments v6.0.2 before merge

Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @M0rgan01

@jolelievre jolelievre merged commit 3efc271 into PrestaShop:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Release drafter not working on zip step
4 participants