Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details link in customer management module config is not valid #23323

Closed
ijzershop opened this issue Sep 1, 2020 · 2 comments · Fixed by PrestaShop/psgdpr#122
Closed

Details link in customer management module config is not valid #23323

ijzershop opened this issue Sep 1, 2020 · 2 comments · Fixed by PrestaShop/psgdpr#122
Labels
1.7.6.8 Affects versions 1.7.7.2 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed GDPR Module: psgdpr Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules Component: Which BO section is concerned

Comments

@ijzershop
Copy link

The url generated in psgdrp at 415: 'customer_link' => $this->context->link->getAdminLink('AdminCustomers', true) . '&viewcustomer&id_customer=',
Does not redirect to the customer information page but the customers overview page because the url is not valid.
The generated url is for example: index.php/sell/customers/?_token=439mm6A-AWILQB2sSXczCo6REgDlbrHfAGdq0XpBpO4&viewcustomer&id_customer=6
but should be: index.php/sell/customers/6/view?_token=439mm6A-AWILQB2sSXczCo6REgDlbrHfAGdq0XpBpO4
@Progi1984 Progi1984 transferred this issue from PrestaShop/psgdpr Feb 19, 2021
@Progi1984 Progi1984 added the GDPR Module: psgdpr label Feb 19, 2021
@hibatallahAouadni
Copy link
Contributor

hibatallahAouadni commented Feb 26, 2021 •
edited
Loading

Hello @ijzershop

Sorry for the late response and thanks for your issue!
I reproduce your issue with PS1.7.7.2 and GDPR v1.2.1, see the attached screenrecord below:

https://drive.google.com/file/d/1mG0SdUi-azEGmyRNMK2mBbSjmD89YlqJ/view

I’ll add this to the debug backlog so that it’s fixed.
If you have already fixed it on your end or if you think you can do it, please do send us a pull request!

PS: it's not a regression cause I reproduce the issue with PS1.7.6.8 and GDPR v1.2.0

Thank you

@hibatallahAouadni hibatallahAouadni added 1.7.6.8 Affects versions 1.7.7.2 Affects versions BO Category: Back Office Bug Type: Bug Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules Component: Which BO section is concerned Ready Status: Issue is ready to be worked on labels Feb 26, 2021
@ghost ghost mentioned this issue Mar 31, 2021
Closed
@florine2623 florine2623 mentioned this issue Oct 25, 2021
Merged
@Progi1984
Copy link
Member

Fixed by @moncef-essid in PrestaShop/psgdpr#122

@prestashop-issue-bot prestashop-issue-bot bot removed the Ready Status: Issue is ready to be worked on label Oct 28, 2021
@hibatallahAouadni hibatallahAouadni added the Fixed Resolution: issue closed because fixed label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.7.6.8 Affects versions 1.7.7.2 Affects versions BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed GDPR Module: psgdpr Minor Severity: minor bug > https://build.prestashop.com/news/severity-classification Modules Component: Which BO section is concerned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct the customer details page link - PS 1.7.7.0
Fix link to Customer
3 participants
@Progi1984 @hibatallahAouadni @ijzershop