Correct the customer details page link - PS 1.7.7.0 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moncef-essid
commented
Dec 26, 2020
•
moncef-essid
commented
| Questions | Answers |
|---|---|
| Description? | The link to the customer details page is broken because the Link::getAdminLink() return the new format link not compatible with legacy params. By the way, Link::getAdminLink() have to be corrected, it return always an url with token, although, the second param setted to false. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | FIxes PrestaShop/PrestaShop#23323 |
| How to test? | tested within PS 1.7.6.9 and 1.7.7.0 |
Get admin link by smarty helper and passed it to js variable, then use it within the vue.js foreach loop with the correct customer id
Use "customer_link" with the contextual "id_customer" taken from the Vue.js loop
Link::getAdminLink() have to be corrected, it return always an url with token, although, the second param to false
PierreRambaud
approved these changes
Oct 5, 2021
|
(Sorry for the delay 🙄 ) |
|
Hello @moncef-essid , Thanks for the PR, checking with the developer if the CI was OK for the checks. |
|
ping @PierreRambaud , I see that the checks are not successful, is everything OK with the CI ? Thanks! |
It's not related to the PR I think, and it only concerns linter. Feel free to test it :) |
|
Hello all, Thanks for the PR @moncef-essid , it is QA approved ! @PierreRambaud thanks :) |
|
Waiting for #148 to be merged so the CI is happy |
|
Thanks @moncef-essid & @atomiix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.