-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hooks when they already exist #669
Conversation
Ping @kpodemski @ShaiMagal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hlavtox
@PrestaShop/qa-functional Guys can I get a QA on this pls? |
815fb7f
185fee3
to
815fb7f
Compare
@matks @jolelievre Please reapprove, I needed to rebase it. It would be good if you could test it, so we don't loose time. Just throw it into phpmyadmin and run it multiple times. |
I guess it would be QA by dev. But could you clarify the steps to reproduce the bugs? 🙏 |
@MatShir Every dev will understand what the PR means and how to test it. :-) |
😩 if you say so ! |
I tested the queries manually and it seems to work perfectly. Just waiting for the CI to be green and we can merge this one. |
Thank you @jolelievre 🚀 The CI is broken on all PRs, the 8.0.0 always fails 🤷♂️ Ping @nesrineabdmouleh @Progi1984 |
go go go @jolelievre you got this 😂 |
@jolelievre Still frozen :( |
4193041
to
e0f0b59
Compare
The CI for 8.0 is still red but it will be fixed in another PR #673 |
Information
INSERT IGNORE
, which doesn't result in an error, but it just doesn't do anything.IGNORE
.hook_name
(name
) exists in 1.6, maybe even sooner.