Fix removing previous module files in PHPStan tests #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Sep 1, 2023
•
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | The previous way of removing the directory didn't work correctly. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Much less frustration thanks to it 😂 |
| How to test? | CI is 🟢 |
kpodemski
force-pushed
the
improved-phpstan-script
branch
from
1de17b2
to
b3278e0
Compare
kpodemski
changed the title
test test2 test3 Fix removing previous directory with a module Test test2
kpodemski
force-pushed
the
improved-phpstan-script
branch
from
d135507
to
cc34098
Compare
kpodemski
changed the title
This was referenced Sep 11, 2023
|
Hi @kpodemski what does this mean
When should we merge this? |
|
Thanks to @leemyongpakvn I understood that "DO NOT MERGE BEFORE RELEASE" actually meant "we dont want to reset the merge PR once again 😭" |
|
We can merge this. I'll get back to the |
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.