Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrestaShop 9 Compability + Namespace fix #10

Merged
merged 3 commits into from
Jul 27, 2023
Merged

PrestaShop 9 Compability + Namespace fix #10

merged 3 commits into from
Jul 27, 2023

Conversation

0x346e3730
Copy link
Member

Questions Answers
Description? Fixes the module's Namespace + compability for PS9
Type? bug fix
BC breaks? yes
Deprecations? no
Fixed ticket? N/A
How to test? Install the module and try to access the "configure" page

@0x346e3730 0x346e3730 marked this pull request as ready for review June 6, 2023 14:18
@0x346e3730 0x346e3730 requested a review from a team June 6, 2023 14:18
matks
matks approved these changes Jun 7, 2023
View reviewed changes
config/services.yml Show resolved Hide resolved
@mflasquin mflasquin force-pushed the ps9 branch 10 times, most recently from 33d3c17 to eb81e55 Compare July 12, 2023 12:55
@mflasquin mflasquin mentioned this pull request Jul 19, 2023
Closed
@mflasquin mflasquin added the Waiting for dev Status: action required, waiting for tech feedback label Jul 20, 2023
@nicosomb nicosomb mentioned this pull request Jul 24, 2023
Merged
@nicosomb
Copy link
Contributor

I tried locally and it seems ok for me.

@nicosomb nicosomb mentioned this pull request Jul 27, 2023
Closed
@mflasquin
Copy link
Contributor

Validated by me and @nicosomb

@mflasquin mflasquin added this to the 1.0.3 milestone Jul 27, 2023
@mflasquin mflasquin removed the Waiting for dev Status: action required, waiting for tech feedback label Jul 27, 2023
@mflasquin mflasquin merged commit a14d94d into PrestaShop:master Jul 27, 2023
@mflasquin
Copy link
Contributor

thanks @0x346e3730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflasquin mflasquin mflasquin approved these changes

@matks matks matks approved these changes

@nicosomb nicosomb nicosomb approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@0x346e3730 @nicosomb @mflasquin @matks