-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct return value for init command #41
Conversation
AJenbo
commented
Dec 8, 2020
Questions | Answers |
---|---|
Description? | This correct a type error when running the phpstan init command |
Type? | bug fix |
BC breaks? | no |
Deprecations? | no |
How to test? | Please indicate how to best verify that this PR is correct. |
src/Command/CsFixerInitCommand.php
Outdated
@@ -36,5 +36,7 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
$destination . '/.' . $template | |||
); | |||
} | |||
|
|||
return self::SUCCESS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have a problem with your phpstan container, because this const is not available before Symfony 5, it failed on Symfony 3 & 4. The composer.lock is targeting the v3.4.42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
composer.lock does not propagate, it's basically meaningless to have it for a library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated it to use an int so that it should be compatible with Symfony 3-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any reason to keep the composer.lock file in this repository 🤔
Thank @AJenbo |