Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow v6.x of Symfony components to be loaded #72

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Allow v6.x of Symfony components to be loaded #72

merged 1 commit into from
Oct 13, 2022

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Oct 10, 2022 •
edited
Loading

Questions Answers
Description? Adding Symfony 6 components to increase compatibility with projects running with latest version. The validator has been upgraded to it, the next step is to require php-dev-tools to reuse the PHP-CS-Fixer configuration file to stay up-to-date.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Requiring this branch via composer works with SF6, while the lastest release does not.
Possible impacts? No impact expected for running projects. The oldest version available will still be required.

lartist
lartist reviewed Oct 10, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
matks
matks approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matks matks merged commit a87a075 into PrestaShop:master Oct 13, 2022
@Quetzacoalt91 Quetzacoalt91 deleted the symfony-v6 branch October 13, 2022 12:05
@matks matks added this to the 4.2.2 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lartist lartist lartist left review comments

@matks matks matks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Quetzacoalt91 @matks @lartist