Skip to content

Commit

Permalink
Merge pull request #159 from leemyongpakvn/remove-yarn-dependency
Browse files Browse the repository at this point in the history
Remove yarn dependency
  • Loading branch information
kpodemski authored Apr 24, 2023
2 parents de5160c + 1c6845f commit 3ac108e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,14 @@ This module is partially compatible with the multistore feature. Some of its opt

### Update dependency

The only dependency for this module (for now) is https://github.com/flaviusmatis/simplePagination.js.git
You can install/update it by launching the command
There is no JS dependency for this module (for now).
You can install PHP dependency by launching the command

```
# yarn install
# composer install
```

(We use yarn because this library is not served as a package for npm).

This will install the library js in views/js folder.
This will install the PHP libraries in vendor folder.

## Reporting issues

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"install": "cp node_modules/simplePagination.js/jquery.simplePagination.js views/js/jquery.simplePagination.js"
"install": "echo \"Error: no install specified\" && exit 1"
},
"repository": {
"type": "git",
Expand All @@ -24,6 +24,5 @@
},
"homepage": "https://github.com/PrestaShop/productcomments#readme",
"dependencies": {
"simplePagination.js": "https://github.com/flaviusmatis/simplePagination.js.git"
}
}
8 changes: 0 additions & 8 deletions yarn.lock

This file was deleted.

0 comments on commit 3ac108e

Please sign in to comment.