Fix duplicated id for review tables #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SD1982
commented
May 17, 2021
•
SD1982
commented
| Questions | Answers |
|---|---|
| Description? | The tables "waiting for approval" , "reported reviews" and "approved reviews" all have the same id this PR fix this |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#24528 |
| How to test? | check the product comments module configuration page, everything should work as before, and also check the html in browser, the id should be different for each table |
matthieu-rolland
approved these changes
May 17, 2021
boubkerbribri
approved these changes
May 17, 2021
|
Why there's no |
Progi1984
approved these changes
May 17, 2021
|
Hi @SD1982 ! The ID are now OK, but I can no longer delete reviews in the different lists (reviews waiting for approval, reported reviews, approved reviews). Could you check that ? Thanks ! |
atomiix
approved these changes
May 24, 2021
boubkerbribri
approved these changes
May 24, 2021
Progi1984
approved these changes
May 25, 2021
|
Hi @SD1982 Now it's OK, the ID are OK and deletion and display of item is OK : QA ✔️ Thanks ! |
|
Thank you @SD1982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.