Remove useless v5 upgrade file, there was no v5 released

[jf-viguier]

Questions	Answers
Description?	Remove this wrong and useless upgrade file, there is no 5.0.0 version (the 4.0.0 has been renamed)
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#24814
How to test?	no way, no 5.0 version

[Progi1984]

@jf-viguier Could you move this commit in the another PR ? It will be more uniform.

[jf-viguier]

thanks Franck

[jf-viguier]

Could you move this commit in the another PR ? It will be more uniform.
Why ? I've posted an issue, it's the rule.

[kpodemski]

@PrestaShop/prestashop-maintainers I'll need access guys 🙏

[matks]

@PrestaShop/prestashop-maintainers I'll need access guys 🙏

Sorry, some repositories access settings are a mess. Fixed ✅

[matks]

Hello, I agree that this upgrade file is useless because there was no v5 release.

However, is the right solution to remove this file or to modify it to become upgrade/install-4.0.0.php ?

I look at the content of the productcomments module, I don't understand why the file upgrade/install-5.0.0.php modifies PRODUCT_COMMENTS_PAGE_COMMENTS_NB constant. I have no idea 😅 .

However I see the constant PRODUCT_COMMENTS_USEFULNESS is being used. So maybe transform upgrade/install-5.0.0.php into upgrade/install-4.0.0.php makes sense.

We can also ask @jolelievre who submitted the PR #26 that added these files to shine some light on this mystery 🕵️

[jf-viguier]

@matks I've done a pr for version 4 upgrade: new hooks and conf values

[kpodemski]

Thx @jf-viguier