Hook on filterProductContent for adding ProductComments data #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Progi1984
commented
Aug 9, 2021
Progi1984
commented
| Questions | Answers |
|---|---|
| Description? | Hook on filterProductContent for adding ProductComments data |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#25372 |
| How to test? | Cf. #25372 |
Progi1984
force-pushed
the
issue25372
branch
2 times, most recently
from
3b21137 to
bf4c839
Compare
kpodemski
reviewed
Aug 9, 2021
Progi1984
force-pushed
the
issue25372
branch
2 times, most recently
from
6f5f3f2 to
8677c7b
Compare
kpodemski
approved these changes
Aug 9, 2021
|
I think we need to create a new milestone and prepare PRs for v4.2.3 |
If you feel like it's important, you can create it 😉 and modify PR milestones. Just make sure changes are correctly targeting 5.0.0 or 4.2.3 . If we created milestone 5.0.0 I think it's because BC breaks have been introduced. |
|
@matks & @kpodemski We need to realease |
|
In this I will rename the upgrade file. |
Progi1984
force-pushed
the
issue25372
branch
2 times, most recently
from
b229b83 to
f745806
Compare
|
@matks & @kpodemski I moved the upgrade file from 4.2.3 to 5.0.0. If you have any time, please review. |
kpodemski
approved these changes
Aug 10, 2021
matthieu-rolland
approved these changes
Aug 30, 2021
|
Hello @Progi1984 , Tested all features of module productcomments, all good to me ! Thanks ! |
|
Thanks @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.