Simplify Type casting #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Assign $id_xyz = (int) $id_xyz once at top, instead of using (int) $id_xyz throughout the function 2. if Validate::isUnsignedId($id_xyz ) then there is no need to type cast (int) ($id_xyz)
if Validate::isUnsignedId($id_product) then there is no need to type cast (int) $id_product
Co-authored-by: Matthieu Rolland <matthieu.rolland@prestashop.com>
2 tasks
MeKeyCool
approved these changes
Jul 4, 2022
ProductComment.php
Outdated
| @@ -95,27 +95,28 @@ public static function getByProduct($id_product, $p = 1, $n = null, $id_customer | |||
| $validate = (bool) Configuration::get('PRODUCT_COMMENTS_MODERATE'); | |||
| $p = (int) $p; | |||
| $n = (int) $n; | |||
| $id_customer = (int) $id_customer; | |||
There was a problem hiding this comment.
Why not using Validate::isUnsignedId as few lines above for $id_product ?
There was a problem hiding this comment.
At line 90, we have $id_customer is an optional parameter and is assigned to null if omitted.
I'm not sure about the logic of that case so I just let it there.
atomiix
approved these changes
Sep 21, 2022
kpodemski
approved these changes
Oct 29, 2022
|
Thanks @leemyongpakvn I didn't notice any regressions during the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2. if Validate::isUnsignedId($id_xyz ) then there is no need to type cast (int) ($id_xyz)