Add validation for 2 positive integer fields

[leemyongpakvn]

Questions	Answers
Description?	Field requires positive integer value need validation before saving
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#28929
How to test?	Check above issue

[ghost]

Hello @leemyongpakvn

Thank you for your involvement in the project
Could you try to use CS-fixer because the test will fail.

Code Before :

Code After :

Thank you again.

[leemyongpakvn]

@okom3pom Thanks for your tool suggestion. I have updated with php-cs-fixer's fixed code.

[leemyongpakvn]

We need a new trans string '%s is invalid. Please enter an integer greater than %s.' in Admin.Notifications.Error also.

[leemyongpakvn]

It looks like there are problems with PHPStan itself, not the PR's code.

[Amoifr]

Thx for this PR. I report 2 types of improvement that can be made for my opinion. I let you take a look on these.

[florine2623]

Hello @leemyongpakvn ,

Thanks for the PR!

Tested the following on 1.7.8.x, 8.0.x and develop branch:
Special characters, accented characters, mix of integer/char, fractioned number, negative number.
If using any of the above characters, it won't save. I have an error message: ✅

But if I enter 0 in BO, it will save. ❌

Therefore, there's an error in FO, I can paginate infinitely: ❌

Screen.Recording.2022-09-15.at.10.43.32.mov

Another thing is missing in the alert: the cross to close it. ❌
For example:

Could you check ?
Thanks!

[leemyongpakvn]

@florine2623 Thanks for testing and informing. I have added one more positive number check and used Module::displayError for close button. @kpodemski has checked again and approved :)

[florine2623]

Hello @leemyongpakvn ,

Tested on 1.7.8.x, 8.0.x, develop.
Looking great !

Alert message is fixed, 0 can't be saved, FO pagination is now OK.

It is QA ✅ !
Thanks!

[kpodemski]

Thanks @leemyongpakvn :)