Improved lastname anonymization #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Nov 18, 2022
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | Anonymization now works for guests and customers |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#30345. |
| How to test? | Please indicate how to best verify that this PR is correct. |
matks
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Code seems ok but I think we need to help developers to understand this new logic. Maybe add a comment or create a private method with a very explicit name?
Also PHPStan is not happy
-- ------------------------------------------------------------------
Error
-- ------------------------------------------------------------------
Ignored error pattern #Access to an undefined property
Cookie::\$id_customer.# was not matched in reported errors.
Ignored error pattern #Access to an undefined property
Cookie::\$id_guest.# was not matched in reported errors.
Ignored error pattern #Access to an undefined property
HelperList::\$list_id.# was not matched in reported errors.
Ignored error pattern #Access to an undefined property
HelperList::\$shopLinkType.# was not matched in reported errors.
-- ------------------------------------------------------------------
kpodemski
force-pushed
the
fix/30345
branch
2 times, most recently
from
2d54f47 to
a69d167
Compare
kpodemski
requested review from
leemyongpakvn and
matks
and removed request for
leemyongpakvn
Hlavtox
approved these changes
Dec 9, 2022
micka-fdz
suggested changes
Dec 9, 2022
fixes remove not needed checks php 5.6 support fix wrong variable name
|
Hello @kpodemski Thanks for your PR. Can we have a second approve before starting testing following @micka-fdz 'feedback review? |
micka-fdz
approved these changes
Dec 9, 2022
Hlavtox
approved these changes
Dec 9, 2022
MhiriFaten
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Hello @kpodemski ,
I have checked your PR, the issue is well fixed!
Untitled_.Dec.9.2022.3_33.PM.webm
So it's QA approved ✔️
Many thanks !
|
Thank you @kpodemski!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.