Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded code #153

Merged
merged 5 commits into from
Mar 2, 2023
Merged

Remove unneeded code #153

merged 5 commits into from
Mar 2, 2023

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? 1. Three functions: renderModerateLists, renderCriterionList, renderCommentsList are only called in productcomment.php getContent that already has 2 require_once at top, so there is no need to require_once again in render functions.
2. The minimum PS_VERSION of version 5.0.2 is 1.7.6, so there is no need to check for PS 1.6 and prior.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? No issue at all. Just beautify the code.
How to test? Apply the PR changes then check module in BO and FO to make sure it works as usual.

@leemyongpakvn leemyongpakvn reopened this Feb 23, 2023
@leemyongpakvn leemyongpakvn reopened this Feb 23, 2023
@leemyongpakvn leemyongpakvn reopened this Feb 23, 2023
@ghost ghost added the waiting for QA label Mar 2, 2023
@MhiriFaten MhiriFaten self-assigned this Mar 2, 2023
@Hlavtox Hlavtox added this to the 5.0.3 milestone Mar 2, 2023
MhiriFaten
MhiriFaten approved these changes Mar 2, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @leemyongpakvn ,

I have checked your PR and LGTM ! ✔️

Thank you 🙏

@Hlavtox Hlavtox merged commit a84f9fb into PrestaShop:dev Mar 2, 2023
@leemyongpakvn leemyongpakvn deleted the remove-unneeded-code branch March 12, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MhiriFaten MhiriFaten MhiriFaten approved these changes

@micka-fdz micka-fdz micka-fdz approved these changes

@lartist lartist lartist approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@MhiriFaten MhiriFaten

Labels
QA ✔️
Projects
None yet
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@leemyongpakvn @matthieu-rolland @lartist @micka-fdz @MhiriFaten @Hlavtox