Release 6.0 #180
Merged
Release 6.0 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Aug 4, 2023
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Release 6.0.0 |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| How to test? | Please perform a full testing of the module as this is a new major release. |
…ination Stop using jquery simple pagination
Remove yarn dependency
…3_phpdevtools-v3.4tov3.16 Update github actions v1v2 to v3, phpdevtools v3.4 to v3.16
…nts.css Remove an unused css file from version 4.0.0
Fix link to website in README
Update build-release.yml using Organization config
…7_moduleVersionTo600 Bump min compatibility to PHP 7.1.3 and PS 1.7.7, module version to 6.0.0
Update README.md
|
Hello @kpodemski @leemyongpakvn , this release is blocking for the issue PrestaShop/PrestaShop#33459. We need to unblock the review to make progress on Doctrine. Do you think the PR #177 can be merged quickly? If not, we can consider proposing another release that includes it. |
|
@M0rgan01 PR 177 was reviewed by @matks and @kpodemski. I answered all questions and applied some suggestions so it's their turn now. And I'm pretty sure that matks don't like bumping to v7.0.0 right after v6.0.0 much ;) |
…o-doctrinedbal-final Migrate from ObjectModel to Doctrine (final)
matthieu-rolland
approved these changes
Aug 23, 2023
tleon
approved these changes
Aug 23, 2023
hibatallahAouadni
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Hello @M0rgan01
I checked every functionalities in the module on 1.7.8.10 and 8.1.1 and it works 🎉
LGTM, QA ✅
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.