If user mistakenly attempts to delete a comment, fail gracefully #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matks
commented
Nov 16, 2023
matks
commented
| Questions | Answers |
|---|---|
| Description? | Fixes 2 issues described in PrestaShop/PrestaShop#34512 : missing redirect after successfull deletion of a comment, and missing handling of bad input when delete is called on a comment that does not exist |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#34512 |
| How to test? | Please follow the ticket instructions |
2 tasks
nicosomb
previously requested changes
Nov 16, 2023
Co-authored-by: Nicolas Lœuillet <nicolas@loeuillet.org>
nicosomb
approved these changes
Nov 16, 2023
leemyongpakvn
approved these changes
Nov 17, 2023
florine2623
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Hello @matks ,
Tested on 1.7.8.x, 8.0.x, 8.1.x and develop.
Works as expected, no more exception.
Screen.Recording.2023-11-17.at.14.27.00.mov
It is QA ✅
|
Thanks @matks and @florine2623 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.