Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable Write your view in QuickView refresh #193

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? The button Write your review should not be displayed in the quick view. More details in the related issue.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#29863
How to test? Apply this PR, then check to make sure Write your review button does not appear in QuickView modal at both First load and Combination change. Write your review must be visible and workable in Product page as usual too ;)

@AureRita AureRita self-assigned this Jan 16, 2024
Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leemyongpakvn

Thank you for your PR, I tested it and it seems to works as you can see :

recording.57.webm

Tested on 8.1.x and Develop

Because the PR seems to works as expected, It's QA ✔️

Thank you

@leemyongpakvn leemyongpakvn merged commit 40614d2 into PrestaShop:dev Jan 16, 2024
8 checks passed
@leemyongpakvn
Copy link
Contributor Author

Thanks @AureRita

@leemyongpakvn leemyongpakvn added this to the 6.0.3 milestone Jan 16, 2024
@florine2623 florine2623 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

FO - product quickview : “Write your review” is unclickable
4 participants