Use on delete cascade on foreign keys

[lmeyer1]

Questions	Answers
Description?	The foreign keys need on delete cascade in order to allow deletion of a product comment.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#35523.
How to test?	Run php bin/console doctrine:schema:update --dump-sql and compare the output. Apply both versions of the SQL script to the DB and test for each the deletion of a product comment in the BO

[leemyongpakva]

Because of this Doctrine magic, we can remove the manual Grade deletion at https://github.com/PrestaShop/productcomments/blob/dev/src/Repository/ProductCommentRepository.php#L117
and mark the corresponding function as Deprecated too https://github.com/PrestaShop/productcomments/blob/dev/src/Repository/ProductCommentRepository.php#L560

[leemyongpakva]

similar to Grade

[leemyongpakva]

similar to Grade

[leemyongpakva]

I think we'd better remove Manual delete after Switching to Doctrine cascade delete.

[lmeyer1]

@leemyongpakva What do you mean by manual delete? In the BO, there is only an option to delete a comment, I didn't find an option to manually delete grades, usefulnesses and reports. Anyway, that would be to complicated.

A working delete button for product comments is a must!

[leemyongpakva]

@leemyongpakva The option to delete a comment in BO will call this snippet https://github.com/PrestaShop/productcomments/blob/dev/productcomments.php#L210-L218, that in turn call https://github.com/PrestaShop/productcomments/blob/dev/src/Repository/ProductCommentRepository.php#L117-L119
Before this PR, this module uses above 3 lines to manually delete ProductComment's grades, reports and usefulness.

[lmeyer1]

@leemyongpakva I see.
Are you sure the code in https://github.com/PrestaShop/productcomments/blob/dev/src/Repository/ProductCommentRepository.php#L117-L119 works?
There the related entities are deleted after $this->remove($entity, true);. Remove the comment will fail if there are related entities present.

Are you sure, the FK are present in your DB ? When I create them in my DB, deletion of a comment no longer works in the BO, unless I also add on delete cascade.

[leemyongpakva]

@lmeyer1 I have just tried deleting a product comment on a PS 8.1.2 site with ProductComment 6.0.2, and the related grades, reports and usefulness are deleted as well. There is no error at all.
In fact, those 3 Manual delete functions can run without FK, they just need $id_product_comment. That's why I called them Manual.

[lmeyer1]

@leemyongpakva
Are you sure, the FK are present in your DB ?

What is the output of php bin/console doctrine:schema:update --dump-sql on your site ? Can you show it?

[leemyongpakva]

Sure, there it is

CRITICAL [console] Error thrown while running command "doctrine:schema:update --dump-sql". Message: "Warning: filemtime(): stat failed for /var/www/html/PrestaShop/vendor/prestashop/autoload/src/Autoloader.php(113) : eval()'d code" ["exception" => ErrorException { …},"command" => "doctrine:schema:update --dump-sql","message" => "Warning: filemtime(): stat failed for /var/www/html/PrestaShop/vendor/prestashop/autoload/src/Autoloader.php(113) : eval()'d code"]

It looks like I haven't got a chance to break my database myself ;) Let's wait other devs checking.