Fix payment method name #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
matks
approved these changes
Jun 6, 2022
kpodemski
approved these changes
Jun 6, 2022
Progi1984
approved these changes
Jun 8, 2022
sLorenzini
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Hi @Matt75,
Thank you for this PR.
Tested with PHP 7.3 version.
Tested with:
- guest and customer account
- spanish and hungarian languages
- check/bankwire/cash on delivery payment method
on:
- BO > Orders page list > Payment column, all translated
- FO > Customer account > Order history and details tab > Payment column on order history list page, all translated
- FO > Customer account > Order history and details tab > Order concerned details link > order details page, all translated
- Confirmation email, all translated
QA approved ✅
Thanks
sLorenzini
added
QA ✔️
|
Thanks @Matt75 & @sLorenzini |
2 tasks
2 tasks
|
Hello I want to add some charge for cash on delivery. So can you please let me know how can I add surcharge/charge who select COD option as payment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules.Cashondelivery.Shoptranslation domain does't not containsCash on deliverystring ; on previous module version 1.0.6$this->module->displayNamewas used, so I restore it.