Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if order is paid with module on displayOrderConfirmation #48

Closed
wants to merge 1 commit into from
Closed

Check if order is paid with module on displayOrderConfirmation #48

wants to merge 1 commit into from

Conversation

Matt75
Copy link
Contributor

@Matt75 Matt75 commented Jun 28, 2022 •
edited by hibatallahAouadni
Loading

Questions Answers
Description? Check if order is paid with Cash on delivery module before display content in hook displayOrderConfirmation
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#28882
How to test? Install ps_cashondelivery module, pay an order using ps_wirepayment module, check in displayOrderConfirmation there no content related to ps_cashondelivery

@Matt75 Matt75 mentioned this pull request Jun 28, 2022
Closed
2 tasks
@kpodemski kpodemski added the waiting for QA Status: Waiting for QA feedback label Jun 28, 2022
@hibatallahAouadni hibatallahAouadni self-assigned this Jun 30, 2022
@hibatallahAouadni
Copy link

Hello @Matt75

Thanks for your PR 🚀
LGTM, QA ✔️

Thanks!

@hibatallahAouadni hibatallahAouadni added QA ✔️ Status: check done, code approved and removed waiting for QA Status: Waiting for QA feedback labels Jul 1, 2022
@kpodemski
Copy link
Contributor

Thanks @Matt75 @hibatallahAouadni

@kpodemski kpodemski added this to the 2.0.1 milestone Jul 1, 2022
@NeOMakinG
Copy link

@Matt75 there is a bug on the PR, it has been merged but is still opened, I'll just close it now

@NeOMakinG NeOMakinG closed this Jul 1, 2022
@jolelievre
Copy link

Indeed, bug from github the PR has been merged in the history but not closed:
Capture d’écran 2022-07-01 à 15 42 40

@Matt75 Matt75 deleted the fix/issue-28882 branch July 1, 2022 17:24
jolelievre pushed a commit that referenced this pull request Jul 15, 2022
@kpodemski
Merge pull request #48 from Matt75/fix/issue-28882
1695f17 
Check if order is paid with module on displayOrderConfirmation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PululuK PululuK PululuK approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@hibatallahAouadni hibatallahAouadni

Labels
QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

COD v2 module displays it's order confirmation template everywhere
6 participants
@Matt75 @hibatallahAouadni @kpodemski @NeOMakinG @jolelievre @PululuK