Make backport return items ordered by position #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
May 9, 2024
•
Hlavtox
commented
| Questions | Answers |
|---|---|
| Description? | In preparation to finalize search controller support, our backport needs to return items in proper position, which we can later use. |
| Type? | refacto |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| How to test? | This is an experimental feature and does not need testing. |
ShaiMagal
approved these changes
Sep 5, 2024
|
@kpodemski Can I merge this as this concerns only the experimental feature implementation? |
florine2623
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Hello @Hlavtox ,
Tested the experimental feature for search in FO ^^
Checked if items were ordered by position. They are order by ID DESC automatically. When edited the position, the search result will update with the current position.
Works as expected ✅
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.