Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added data-name to distinguish facet #1043

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Added data-name to distinguish facet #1043

merged 2 commits into from
Jun 21, 2024

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Jun 20, 2024 •
edited
Loading

Questions Answers
Description? Added data-name to distinguish facet for improving tests on modules
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

@Progi1984 Progi1984 mentioned this pull request Jun 21, 2024
Merged
@nicosomb nicosomb merged commit e2790ad into PrestaShop:dev Jun 21, 2024
11 checks passed
@Progi1984 Progi1984 deleted the dataFacets branch June 21, 2024 13:13
@Progi1984
Copy link
Member Author

No need QA. It's already validated by UI Tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

Assignees
No one assigned
Labels
enhancement QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Progi1984 @nicosomb @ps-jarvis