-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve availability filter #883
Conversation
76f8202
to
419b83d
Compare
ca0561b
to
f013b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some uneducated feedback... and also I'm wondering if this should be validated by @MatShir before being QAed and merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like product aproves (@MatShir ) 👍
LGTM codewise
Hi @Hlavtox Thank you for your PR, All seems to works as you can see here : Untitled_.Jul.24.2023.5_03.PM.webmTested on : I see just a little issue on it : Untitled_.Jul.24.2023.5_31.PM.webmI don't think this one'll block this PR so it's QA ✔️ Thank you |
🥳 |
Changes
How it looks - nicely ordered, if there is something orderable but not in stock, it is still displayed
But when they are the same 7 products, or merchant does not allow out-of-stock ordering globally, it won't get displayed
This change is