Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added data-type to distinguish facet #893

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Added data-type to distinguish facet #893

merged 1 commit into from
Aug 2, 2023

Conversation

Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Aug 2, 2023 •
edited by eternoendless
Loading

Questions Answers
Description? Added data-type to distinguish facet for improving tests on modules
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? N/A

This change is Reviewable

@Progi1984 Progi1984 added this to the 3.13.1 milestone Aug 2, 2023
@Progi1984 Progi1984 requested a review from a team August 2, 2023 14:28
@Progi1984
Copy link
Member Author

@kpodemski No need QA. UI tests validate it 😉

@Progi1984 Progi1984 mentioned this pull request Aug 2, 2023
Merged
@Hlavtox Hlavtox merged commit 5b2086c into PrestaShop:dev Aug 2, 2023
@Progi1984 Progi1984 deleted the testDataType branch August 2, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
PR Dashboard
Archived in project
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Progi1984 @kpodemski @Hlavtox @ps-jarvis