-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting by reference #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you have an issue/discussion related ? If so, please add the link to your PR description. |
Hi @florine2623 There is no issue or discussion but this is a common demand as merchant. To test, go to a category page and click on the sort button. You will see the choice of sorting by reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @LameuleFR ,
I have checked your PR and the sorting by reference is well added in the PrestaShop category page and works as expected.
LGTM 🟢
It is QA approved !
Thanks.
thank you @LameuleFR |
Some merchants don't use references, so this sorting is not relevant for them. |
In most case merchant will use references but we can probably add a configuration field in the module to activate/deactivate this behaviour. |
@LameuleFR It would be great to have a simple configuration for every sort option 👍🏻 |
This change is