Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting by reference #925

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add sorting by reference #925

merged 1 commit into from
Sep 26, 2023

Conversation

LameuleFR
Copy link
Contributor

@LameuleFR LameuleFR commented Sep 20, 2023

Questions Answers
Description? Add sorting by reference in the prestashop categorie page.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Check that on the category with filters there is a new sorting option available

This change is Reviewable

Copy link
Contributor

@mflasquin mflasquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florine2623
Copy link
Contributor

@LameuleFR ,

Do you have an issue/discussion related ? If so, please add the link to your PR description.
If not, please describe How to test your PR description.

@florine2623 florine2623 added waiting for author Waiting for author's feedback and removed Waiting for QA labels Sep 21, 2023
@LameuleFR
Copy link
Contributor Author

LameuleFR commented Sep 21, 2023

Hi @florine2623

There is no issue or discussion but this is a common demand as merchant.

To test, go to a category page and click on the sort button. You will see the choice of sorting by reference
https://i.gyazo.com/3a84b67f11918e0e42a6c12001464588.png

@kpodemski kpodemski added Waiting for QA and removed waiting for author Waiting for author's feedback labels Sep 25, 2023
@MhiriFaten MhiriFaten self-assigned this Sep 26, 2023
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @LameuleFR ,

I have checked your PR and the sorting by reference is well added in the PrestaShop category page and works as expected.

LGTM 🟢

It is QA approved !
Thanks.

@kpodemski kpodemski modified the milestones: 3.14, 3.14.0 Sep 26, 2023
@kpodemski kpodemski merged commit 43a4b14 into PrestaShop:dev Sep 26, 2023
11 checks passed
@kpodemski
Copy link
Contributor

thank you @LameuleFR

@jf-viguier
Copy link
Contributor

Some merchants don't use references, so this sorting is not relevant for them.

@LameuleFR
Copy link
Contributor Author

In most case merchant will use references but we can probably add a configuration field in the module to activate/deactivate this behaviour.

@kpodemski
Copy link
Contributor

@LameuleFR It would be great to have a simple configuration for every sort option 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants