This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Fix multilingual strings displayed in frontend hooks #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
This fixes PrestaShop/PrestaShop#9766 |
rblaurin
approved these changes
Mar 14, 2019
|
This is an important fix and it is working like a charm ;) |
|
Hello @alexej-d |
|
Fixes PrestaShop/PrestaShop#9766 Thank you @alexej-d |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix the caching system only caches a single language version of any frontend block, which renders multilanguage shops impossible, as the same language version of the templates is displayed for every shop language.
Before the patch hookDisplayProductPriceBlock_price.tpl renders this following text:
In the english shop
Shipping excludedand this text in e.g. the german shop
Shipping excludedAfter the patch hookDisplayProductPriceBlock_price.tpl renders this following (correct) text:
In the english shop
Shipping excludedand this text in e.g. the german shop
Zzgl. Versandkosten