Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.1 #105

Merged
merged 8 commits into from
Sep 28, 2020
Merged

Release v1.2.1 #105

merged 8 commits into from
Sep 28, 2020

Conversation

matks
Copy link
Contributor

@matks matks commented Sep 21, 2020

ChangeLog

This release is needed to enable compatibility with PrestaShop 1.7.7.0

@marionf
Copy link
Contributor

marionf commented Sep 25, 2020

Here are the tests done: https://drive.google.com/file/d/13Kup_qNwJ_Sb24hWWI3ey4nzJwDwp24v/view?usp=sharing

  1. For the issue Module GDPR does not hide adresses in 1.7.7 Order page PrestaShop#20605:
  • Delete a customer with an order from the BO with the first option "I want my customers to be able to register again with the same email address. All data will be removed from the database." > The addresses are well not displayed in the order after the deletion ✔️
  • Delete a customer with an order from the BO with the second option "I do not want my customer(s) to register again with the same email address. All selected customer(s) will be removed from this list but their corresponding data will be kept in the database." > The addresses are still displayed in the order after the deletion ✔️
  • Delete a customer with an order from the GDPR module > The addresses are well not displayed in the order after the deletion ✔️
  1. Non regressions tests:

It's a QA ✔️ for me

@matks
Copy link
Contributor Author

matks commented Sep 25, 2020

As seen with Modules team, merge is scheduled to happen on Monday following the "Dont push to production on Friday" principle

@matks matks merged commit 3b5240b into master Sep 28, 2020
@matks matks deleted the dev branch September 28, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants