Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module data not being showed #109

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

atomiix
Copy link
Contributor

@atomiix atomiix commented Oct 30, 2020

Questions Answers
Description? Because of a bad if statement, modules' personal data were not displayed in MANAGE CUSTOMER'S PERSONAL DATA tab of the GDPR module configuration page.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? 1. Be sure that productcomments and/or ps_emailsubscription module is installed and enabled
2. Go to Improve > Module > Module Manager
3. Look for Official GDPR compliance and click on Configure
4. On the personal data management tab, search for John Doe and click on it
5. You should have a section calledMODULE: PRODUCT COMMENTS and/or MODULE: NEWSLETTER SUBSCRIPTION in the part that just opened.

@PierreRambaud PierreRambaud added waiting for QA bug Something isn't working labels Nov 9, 2020
@khouloudbelguith
Copy link

Hi @atomiix

It is ok ✔️
BO:
image
FO
image

Thanks!

@PierreRambaud PierreRambaud merged commit 39bc382 into PrestaShop:dev Dec 21, 2020
@PierreRambaud
Copy link
Contributor

Thank you @atomiix

@atomiix atomiix deleted the fix/wrong-condition branch December 22, 2020 12:41
@Progi1984 Progi1984 added this to the 1.3.0 milestone Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA ✔️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants