Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply license headers from native modules #137

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Apply license headers from native modules #137

merged 1 commit into from
Mar 1, 2021

Conversation

matks
Copy link
Contributor

@matks matks commented Feb 28, 2021

Questions Answers
Description? Apply license headers from other native modules like https://github.com/PrestaShop/ps_facetedsearch/
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

@matks
Copy link
Contributor Author

matks commented Feb 28, 2021

GitHub Action PHP-CS-Fixer fails although locally it finds no issue.
#138 fixes this

@atomiix atomiix closed this Mar 1, 2021
@atomiix atomiix reopened this Mar 1, 2021
@matks
Copy link
Contributor Author

matks commented Mar 1, 2021

Thank you for review !

@matks matks added this to the 1.3.0 milestone Mar 1, 2021
@matks matks merged commit a6cb257 into PrestaShop:dev Mar 1, 2021
@matks matks deleted the fix-license-headers branch March 1, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiix atomiix atomiix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@matks @atomiix