Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data to type option in ajax request #146

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

PrestaEdit
Copy link
Contributor

@PrestaEdit PrestaEdit commented Oct 18, 2021

Questions Answers
Description? There is two data options and the POST need to be one of type/method.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#23325
How to test? Verify the behavior of 'GDPR consent' checkbox on FO

@NeOMakinG
Copy link

wtf

@hibatallahAouadni
Copy link

Hello @PrestaEdit

Thanks for your PR!
All LGTM, QA ✔️

Thanks!

@Progi1984 Progi1984 added this to the 1.3.0 milestone Nov 2, 2021
@Progi1984 Progi1984 merged commit c5d83ef into PrestaShop:dev Nov 2, 2021
@Progi1984
Copy link
Member

Thanks @PrestaEdit & @hibatallahAouadni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong javascript arg on /psgdpr/views/templates/hook/displayGDPRConsent.tpl:67 (data instead method)
5 participants