-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.4.2 #172
Release 1.4.2 #172
Conversation
PierreRambaud
commented
Apr 11, 2022
Questions | Answers |
---|---|
Description? | Release a new version |
Update anonymous password
Bump to 1.4.2 and make sure password is correctly encoded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @PierreRambaud ,
Thanks for the PR !
In BO > Modules > psgdpr > Get started Tab, there is just a little wording to correct :
Could you check please ?
Thanks!
Done in #173 |
Fix wordings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @PierreRambaud ,
Thanks for the PR !
Tested on 1.7.8.x :
- Upgrade to 1.4.2 went well
- Wording is fixed
- Action buttons work well
- In PS 1.7.8.x, in customer account all actions are OK
- Update anonymous password #170 OK
- Bump to 1.4.2 and make sure password is correctly encoded #171 OK
I am encountering some issues on develop branch.
- In FO customer account, the module is not hooked to displayCustomerAccount. I can't access the gdpr block as a customer 🚫
- Bump to 1.4.2 and make sure password is correctly encoded #171 is NOK 🚫
- Update anonymous password #170 OK
- Wording is fixed
- Action buttons work well
@florine2623 I don't manage to reproduce the issue: But I added #174 which should fix one issue |
Fix anonymous user if it's already in database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @PierreRambaud ,
It is looking good to me.
Tested on PS 1.7.8.x and develop with PHP 7.4. The password is well encrypted ✅
The gdpr blocks on FO customer account is well displayed ✅
I checked :
Actions buttons are working well
Overall features work well too (modified checkbox consent, downloaded data from BO and FO)
It is QA ✅
Sorry, I'm new on Github. And the correction where I can find?
GoT ***@***.***> escreveu em ter., 19/04/2022 às 08:51 :
… Hi,
When the checkbox is ignored, after clicking forward on the form, Chrome
cannot find the field marked "required" [image: chrome_UqSDQWLZbc]
<https://user-images.githubusercontent.com/86001662/163819924-f664f7f2-c02d-4cc2-8f6b-ebeba62b7a61.png>
It's another bug, already present in previous releases, not related to
this one. But thank you for noticing us!
—
Reply to this email directly, view it on GitHub
<#172 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUQEP7W7TOUFAMZGSR2VEN3VFZQYZANCNFSM5TDS2YAA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hello, after I've upgraded psgdpr module to version 1.4.2, when I click on the button to access to the module's configuration page, it appears an error 500 page. My Prestashop version is 1.7.5.2. |