Fix hook registration if needed #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpodemski
commented
Dec 9, 2022
•
kpodemski
commented
| Questions | Answers |
|---|---|
| Description? | Sometimes hook wasn't registered. This PR adds a migration script from v1.4.2 to v1.4.3 that performs the following logic: "if the hook displayGDPRConsent was not registered for this module, I register it" |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes PrestaShop/PrestaShop#30348. |
| How to test? | Please see ticket. You need a usecase where GDPR module is installed (v1.4.2) and the hook displayGDPRConsent is not registered for the module. See if checkboxes are displayed after GDPR upgrade module to 1.4.3. |
Merged
kpodemski
force-pushed
the
fix-displaying-checkboxes
branch
from
d49a8a5
to
2f37402
Compare
matks
approved these changes
Dec 9, 2022
|
@kpodemski I improved a bit the PR description and How to test ;) |
There was a problem hiding this comment.
Hello @kpodemski
Thanks for your PR 🚀
LGTM except the creation of account, where the consent checkbox is not displayed 😞
Even thought, in BO the option is enabled, see the attached screenshot below:
See the attached screen record below:
psgdpr_183.webm
Please check and feedback.
Thanks!
|
Thanks @hibatallahAouadni ! I've fixed it, it was indeed a problem as the id of the page is not |
nicosomb
approved these changes
Dec 12, 2022
|
Thanks @hibatallahAouadni ! |
gurkcity
pushed a commit
to gurkcity/psgdpr
that referenced
this pull request
Jun 28, 2023
…boxes Fix hook registration if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.