Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load assets correct dir for javascript files #184

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Markus-Gurkcity
Copy link
Contributor

@Markus-Gurkcity Markus-Gurkcity commented Jan 27, 2023

Questions Answers
Description? The assets for the module admin configuration are not loaded correctly. The wrong folder is specified.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Make sure javascript files in the module are loaded correctly tiny_mce/tiny_mce.js & admin/tinymce.inc.js

Copy link

@djoelleuch djoelleuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Markus-Gurkcity ,

LGTM , It's QA approved ✔️

thank you !

@kpodemski kpodemski added this to the 1.5.0 milestone Feb 20, 2023
@kpodemski kpodemski merged commit d49fa6a into PrestaShop:dev Feb 20, 2023
@kpodemski
Copy link
Contributor

Thank you @Markus-Gurkcity !

@Hlavtox Hlavtox modified the milestones: 1.5.0, 2.0.0 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants