Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove isset condition because variables always set #185

Merged
merged 3 commits into from
Feb 22, 2023
Merged

remove isset condition because variables always set #185

merged 3 commits into from
Feb 22, 2023

Conversation

Markus-Gurkcity
Copy link
Contributor

@Markus-Gurkcity Markus-Gurkcity commented Jan 27, 2023 •
edited by kpodemski
Loading

Questions Answers
Description? In front ajax gdpr controller there is a condition to prove that a variable is set. but the variables are always set.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? See if consents are properly logged to BO

mflasquin
mflasquin reviewed Jan 30, 2023
View reviewed changes
controllers/front/FrontAjaxGdpr.php Outdated Show resolved Hide resolved
controllers/front/FrontAjaxGdpr.php Outdated Show resolved Hide resolved
Markus-Gurkcity and others added 2 commits January 31, 2023 08:04
@Markus-Gurkcity @mflasquin
Update controllers/front/FrontAjaxGdpr.php
3df7e29 
Co-authored-by: Maxime Flasquin <maxime-flasquin.ext@prestashop.com>
@Markus-Gurkcity @mflasquin
Update controllers/front/FrontAjaxGdpr.php
bca23f8 
Co-authored-by: Maxime Flasquin <maxime-flasquin.ext@prestashop.com>
@MhiriFaten MhiriFaten self-assigned this Feb 21, 2023
MhiriFaten
MhiriFaten approved these changes Feb 22, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Markus-Gurkcity ,

I have checked your PR and LGTM !
QA ✔️

Thank you

@Progi1984 Progi1984 added this to the 1.5.0 milestone Feb 22, 2023
@Progi1984 Progi1984 added the bug Something isn't working label Feb 22, 2023
@kpodemski kpodemski merged commit f263e2a into PrestaShop:dev Feb 22, 2023
@kpodemski
Copy link
Contributor

thank you @Markus-Gurkcity

@Hlavtox Hlavtox modified the milestones: 1.5.0, 2.0.0 Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflasquin mflasquin mflasquin left review comments

@MhiriFaten MhiriFaten MhiriFaten approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@MhiriFaten MhiriFaten

Labels
bug Something isn't working QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Markus-Gurkcity @kpodemski @mflasquin @MhiriFaten @Progi1984 @Hlavtox