Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: entity repository #193

Merged
merged 8 commits into from
Mar 28, 2023
Merged

fix: entity repository #193

merged 8 commits into from
Mar 28, 2023

Conversation

fox-john
Copy link
Contributor

Questions Answers
Description? update of repositories working with an entity to extends directly ServiceEntityRepository
Type? improvement
BC breaks? no
Deprecations? no
How to test? test all functionality of app for regression check

@fox-john fox-john mentioned this pull request Mar 23, 2023
Merged
@fox-john fox-john marked this pull request as ready for review March 27, 2023 07:34
@paulnoelcholot
Copy link

Hello @fox-john,

I have tested your PR and I found a bug 😢

From the FO there is a problem with the import of its data in PDF format

https://watch.screencastify.com/v/6bnMTnFirK4FP9K64cnZ

@RosaBenouamer RosaBenouamer mentioned this pull request Mar 28, 2023
Closed
13 tasks
@paulnoelcholot
Copy link

Hello @fox-john,

I have tested your PR and it's good for me! 🎉

Thanks!

@Progi1984 Progi1984 added this to the 2.0.0 milestone Mar 28, 2023
@lartist lartist merged commit 094b7dc into PrestaShop:dev Mar 28, 2023
@lartist
Copy link
Contributor

lartist commented Mar 28, 2023

Thanks @fox-john

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnoelcholot paulnoelcholot paulnoelcholot approved these changes

@lartist lartist lartist approved these changes

Assignees
No one assigned
Labels
QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fox-john @paulnoelcholot @lartist @Progi1984