Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add composer validate in php.yml #195

Merged
merged 1 commit into from
Mar 27, 2023
Merged

fix: add composer validate in php.yml #195

merged 1 commit into from
Mar 27, 2023

Conversation

fox-john
Copy link
Contributor

Questions Answers
Description? Add verification of composer files in CI/CD.
Type? improvement
BC breaks? no
Deprecations? no
How to test? just check if CI/CD work correctly

@fox-john fox-john force-pushed the feature/add-composer-validate-to-ci branch from ed6fd7b to 6d1657e Compare March 27, 2023 08:46
@fox-john fox-john force-pushed the feature/add-composer-validate-to-ci branch from cce9b4a to 6d1657e Compare March 27, 2023 09:52
@jolelievre
Copy link
Contributor

This part only deals with addition check in the CI which is green here, so I don't think it needs a manual QA

@jolelievre jolelievre merged commit 1b4310a into PrestaShop:dev Mar 27, 2023
@jolelievre
Copy link
Contributor

Thanks @fox-john

@RosaBenouamer RosaBenouamer mentioned this pull request Mar 28, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolelievre jolelievre jolelievre approved these changes

@lartist lartist lartist approved these changes

Assignees
No one assigned
Labels
waiting for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fox-john @jolelievre @lartist