Fix install query and upgrade #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 24, 2023 12:03
Closed
2 tasks
mflasquin
approved these changes
Aug 28, 2023
aniszr
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Hello @matthieu-rolland
I tested your PR and with both recommended tests in your description :
- First test
- The upgrade process went well from 8.0.4 to 8.1.1 with psgdpr module installed from the PR ✔️
See attached video record:
Module.manager.Prestashop8.04.mp4
- Second test
-
The PR module in copied to autoupgrade/modules/psgdpr.zip
-
The upgrade process went well, but the psgdpr module is not updated corresponding to the version copied in local file ❌
See attached screenrecord:
Module.manager.Prestashop804.mp4
|
@matthieu-rolland what is the status of this PR ? |
As I tested it it's work in progress, I'm on it |
|
PR ready again |
|
new PR incoming, on a branch of my own |
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Install PS 8.0.4
- uninstall psgdpr
- install psgdpr (using a zip from this PR)
- upgrade PS to 8.1.1
Second test:
1/ Install PS8.0.4
2/ have psgdpr 2.0 or 1.4.3 installed
3/ Upgrade to 8.1.1 (while having psgdpr to upgrade with this PR, not sure how to do this?)