Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.3 #222

Closed
wants to merge 8 commits into from
Closed

Release 2.0.3 #222

wants to merge 8 commits into from

Conversation

M0rgan01
Copy link
Contributor

Questions Answers
Description? Release 2.0.3
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Global testing as it's a release

@M0rgan01 M0rgan01 added this to the 2.0.3 milestone Sep 28, 2023
@MatShir
Copy link

MatShir commented Sep 29, 2023

@MhiriFaten Could you share the test performed ?

Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking just to be sure it is not merged by mistake

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @M0rgan01 ,

Tested on 1.7.8.10, 8.0.x, 8.1.2 and develop branch.
With PHP 8.1.13

Tested the following :

PRs:

Issues:

For 8.1.2 and develop

Attempted to load class "ConsentRepository" from namespace "PrestaShop\Module\Psgdpr\Repository".
Did you forget a "use" statement for another namespace?
Screenshot 2023-10-02 at 12 40 20

Other issues found during this test :

Only on develop:
There's an exception when I click on psgdpr > Configure > Personal data management > Search for a customer name : John > Details

An exception has been thrown during the rendering of a template ("Unable to generate a URL for the named route "admin_products_v2_preview" as such route does not exist.").
Screenshot 2023-10-02 at 13 00 32

On PS 1.7.8.10, psgdpr breaks the FO : ❌ ❌ ❌
With 1.4.3 :

(1/1) ServiceNotFoundException
You have requested a non-existent service "PrestaShop\Module\Psgdpr\Repository\ConsentRepository".
Screenshot 2023-10-02 at 13 39 14 After the upgrade, with `2.0.3` :
(1/1) UndefinedMethodException
Attempted to call an undefined method named "fetchAssociative" of class "Doctrine\DBAL\Driver\PDOStatement".
Screenshot 2023-10-02 at 13 43 09

In BO, the module can't be configured even after the upgrade to 2.0.3 :

Attempted to call an undefined method named "fetchOne" of class "Doctrine\DBAL\Driver\PDOStatement".
Screenshot 2023-10-02 at 13 46 36

@paulnoelcholot
Copy link

Hello,

On 8.1.1 --> multistore enable --> autoupgrade to 8.1.2 --> on psgdpr if I check the checkbox to apply the context of the shop I got this error:

image

If I leave the module and try to configure it again, I have the same error.

Remove PULL_REQUEST_TEMPLATE.md
@Hlavtox
Copy link
Contributor

Hlavtox commented Oct 4, 2023

@florine2623

PrestaShop/PrestaShop#33800
PrestaShop/PrestaShop#33794

@jolelievre jolelievre closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.