-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.3 #222
Release 2.0.3 #222
Conversation
M0rgan01
commented
Sep 28, 2023
Questions | Answers |
---|---|
Description? | Release 2.0.3 |
Type? | improvement |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | - |
How to test? | Global testing as it's a release |
Better check if record is active
Fix sha1 deprecation
bump version 2.0.3
@MhiriFaten Could you share the test performed ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking just to be sure it is not merged by mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @M0rgan01 ,
Tested on 1.7.8.10
, 8.0.x
, 8.1.2
and develop
branch.
With PHP 8.1.13
Tested the following :
PRs:
- Better check if record is active #218 ✅
- Fix sha1 deprecation #219 ✅
- bump version 2.0.3 #220 ✅ upgrade to 2.0.3 OK, BUT only when I uninstall API distribution module (on
8.1.2
anddevelop
. on1.7.8.10
and8.0.x
upgrades are OK). If the module API Distribution is enabled, I will have the message saying that the module is well installed, but in the modules list, the version number is wrong.
Issues:
For 8.1.2
and develop
- It is not possible to activate the module for the context of the shop with GDPR 2.0.x PrestaShop#32211 ❌ still not good with 2.0.3
There's no way to configure back the module, even when the multistore option is disabled. Also, on the FO, the option is erased from the customer'x account.
You have the Reset the module in order to make it work again.
Attempted to load class "ConsentRepository" from namespace "PrestaShop\Module\Psgdpr\Repository".
Did you forget a "use" statement for another namespace?
- Consent checkbox is not displayed even when enabled PrestaShop#30348 ❌
I had to go toDesign > Positions > Hook a module > GDPR > Save
in order to get all the checkboxes displayed in FO. It is not automatically displayed.
Other issues found during this test :
Only on develop
:
There's an exception when I click on psgdpr > Configure > Personal data management > Search for a customer name : John > Details
An exception has been thrown during the rendering of a template ("Unable to generate a URL for the named route "admin_products_v2_preview" as such route does not exist.").
On PS 1.7.8.10
, psgdpr breaks the FO : ❌ ❌ ❌
With 1.4.3
:
(1/1) ServiceNotFoundException
You have requested a non-existent service "PrestaShop\Module\Psgdpr\Repository\ConsentRepository".
(1/1) UndefinedMethodException
Attempted to call an undefined method named "fetchAssociative" of class "Doctrine\DBAL\Driver\PDOStatement".
In BO, the module can't be configured even after the upgrade to 2.0.3 :
Attempted to call an undefined method named "fetchOne" of class "Doctrine\DBAL\Driver\PDOStatement".
Remove PULL_REQUEST_TEMPLATE.md