bug fix upgrade 1.1.0 #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jf-viguier
commented
Oct 4, 2024
jf-viguier
commented
| Questions | Answers |
|---|---|
| Description? | Please be specific when describing this change. What did you change? Why? |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | no |
| Sponsor company | Friends of Presta |
| How to test? | Upgrade to 1.1.0 and check hook registration |
Touxten
approved these changes
Oct 4, 2024
kpodemski
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Hello @jf-viguier
I'm not sure about your change.
You check if the hook doesn't exist, and if it doesn't exist, do you want to unregister it? The original condition seems correct.
|
Yes my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.