Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDPR isn't working if the module have multiple form on same page #64

Merged
merged 1 commit into from
Apr 3, 2020
Merged

GDPR isn't working if the module have multiple form on same page #64

merged 1 commit into from
Apr 3, 2020

Conversation

PeeyushAgrawal
Copy link
Contributor

@PeeyushAgrawal PeeyushAgrawal commented Sep 21, 2019 •
edited by PierreRambaud
Loading

Questions Answers
Branch? develop
Description? This PR fixes PrestaShop/PrestaShop#14429.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#14429
How to test? can test with the test module that I have commented on the issue PrestaShop/PrestaShop#14429.
Install the gdpr module (with the changes) and test gdpr module (shared on the issue), now user can use multiple forms by using a single module.

@PeeyushAgrawal PeeyushAgrawal mentioned this pull request Sep 21, 2019
Closed
@Progi1984 Progi1984 changed the title fixes the issue_GDPR isn't working if the module have multiple form o… GDPR isn't working if the module have multiple form on same page Jan 17, 2020
@Matt75
Copy link
Contributor

Matt75 commented Apr 2, 2020

@NeOMakinG Maybe you will be more efficient to review this than me 😊

NeOMakinG
NeOMakinG approved these changes Apr 2, 2020
View reviewed changes
Copy link

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks way better, nothing to say except that using strict operators is a good practice that you should apply :)

Thanks for your contribution

@Matt75 Matt75 added waiting for QA bug Something isn't working and removed Waiting for review labels Apr 2, 2020
@sarahdib sarahdib self-assigned this Apr 3, 2020
@Progi1984 Progi1984 merged commit 08b1d66 into PrestaShop:dev Apr 3, 2020
@Progi1984
Copy link
Member

Thanks @peeyushagrawalwebkul

@Quetzacoalt91 Quetzacoalt91 mentioned this pull request Jul 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeOMakinG NeOMakinG NeOMakinG approved these changes

Assignees
No one assigned
Labels
bug Something isn't working QA ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PeeyushAgrawal @Matt75 @Progi1984 @NeOMakinG @sarahdib @pablopolyte